Merged
Conversation
Changed the target framework in ConsoleApp4.vbproj from netcoreapp3.1 to net10.0 to upgrade the project to a newer .NET version.
…t since they will likely screw up for name clashes anyway
…ately runnable file I made to test the approach
…for this upgrade is installed on the machine and if not, help to get it installed'
Converted CSharpConsoleApp.csproj from the legacy .NET Framework project format to the modern SDK-style format. Updated the target framework to net10.0, removed redundant property groups and references, and simplified the ProjectReference element. This streamlines the project file and aligns it with current .NET best practices.
Eliminated references to microsoft.visualbasic, System.Data.DataSetExtensions, and Microsoft.CSharp from the CSharpConsoleApp.csproj file, streamlining project dependencies. No other changes were made.
…t enforces having precisely one match
…s in spite of RS1039, so we'll try to get a release out before addressing that
GrahamTheCoder
force-pushed
the
update-to-supported-dotnet
branch
from
48c04b0 to
b43cbd9
Compare
GrahamTheCoder
force-pushed
the
update-to-supported-dotnet
branch
from
3d65f70 to
b18def1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove direct attempts to support running dot net framework apps. It may still partially work in some cases, but using an older version of the converter would be wisest. It also removes the web app's api and cuts it down to a host of static files with the function always providing the api.
Why
It's very hard to find a balance between old and new, particularly around dot net framework and msbuild versions.
Instead, we'll target the latest LTS version of dot net and use old builds to satisfy people who turn up with ancient projects that need converting, or advise them to upgrade to the latest dot net first.
Solution
Still need to look into a couple of test failures but wanted to check if this works on CI system.